FailedChanges

Summary

  1. [lldb/DWARF] Add is_dwo member to DWARFUnit (details)
  2. [lldb/DWARF] Fix mixed v4+v5 location lists (details)
  3. Fix "pointer is null" static analyzer warning. NFCI. (details)
  4. Fix "pointer is null" static analyzer warning. NFCI. (details)
  5. [NFC][ARM] LowOverheadLoop comments (details)
Commit 9bb01efa49ca7f069bc7acba7e4c9bf64d972e79 by pavel
[lldb/DWARF] Add is_dwo member to DWARFUnit
Summary: A skeleton unit can easily be detected by checking the
m_dwo_symbol_file member, but we cannot tell a split unit from a normal
unit from the
"inside", which is sometimes useful.
This patch adds a m_is_dwo member to enable this, and align the code
with llvm::DWARFUnit. Right now it's only used to avoid creating a split
unit inside another split unit (which removes one override from
SymbolFileDWARFDwo and brings us a step closer to deleting it), but my
main motivation is fixing the handling of location lists in mixed v4&v5
files. This comes in a separate patch.
Reviewers: JDevlieghere, aprantl, clayborg
Subscribers: dblaikie, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71750
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFTypeUnit.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFContext.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
Commit cd5da94d80b2b0f2bdb2d0157e24705a4cbd2a4e by pavel
[lldb/DWARF] Fix mixed v4+v5 location lists
Summary: Our code was expecting that a single (symbol) file contains
only one kind of location lists. This is not correct (on non-apple
platforms, at least) as a file can compile units with different dwarf
versions.
This patch moves the deteremination of location list flavour down to the
compile unit level, fixing this problem. I have also tried to rougly
align the code with the llvm DWARFUnit. Fully matching the API is not
possible because of how lldb's DWARFExpression lives separately from the
rest of the DWARF code, but this is at least a step in the right
direction.
Reviewers: JDevlieghere, aprantl, clayborg
Subscribers: dblaikie, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71751
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp
The file was modifiedlldb/source/Expression/DWARFExpression.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
The file was modifiedlldb/include/lldb/Expression/DWARFExpression.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
The file was addedlldb/test/Shell/SymbolFile/DWARF/debug_loc_and_loclists.s
Commit d462185e8daa49889c31c8f5568749e379a5ddf9 by llvm-dev
Fix "pointer is null" static analyzer warning. NFCI.
Use cast<> instead of dyn_cast<> since we know that the pointer should
be valid (and is dereferenced immediately below).
The file was modifiedclang/lib/Sema/SemaTemplateInstantiateDecl.cpp
Commit 25dd99fab205619ef90d0da23bcfba3c9f762e5e by llvm-dev
Fix "pointer is null" static analyzer warning. NFCI.
Use cast<> instead of dyn_cast<> since we know that the pointer should
be valid (and is dereferenced immediately).
The file was modifiedllvm/lib/IR/Verifier.cpp
Commit 9c91d79dadc660cb6a0ec736389341debd8cd118 by sam.parker
[NFC][ARM] LowOverheadLoop comments
Add a comment describing the dependencies of the pass.
The file was modifiedllvm/lib/Target/ARM/ARMLowOverheadLoops.cpp