FailedChanges

Summary

  1. [DFAPacketizer] Fix large compile-time regression for VLIW targets (details)
  2. [AMDGPU][MC][GFX10] Added sdwa/dpp versions of v_cndmask_b32 (details)
  3. Update MinidumpYAML to use minidump::Exception for exception stream (details)
  4. LLDB: Use LLVM's type for minidump ExceptionStream [NFC] (details)
  5. ProcessMinidump: Suppress reporting stop for signal '0' (details)
  6. [tooling] Relax an assert when multiple GPU targets are specified. (details)
  7. [clang-format] fix regression recognizing casts in Obj-C calls (details)
  8. Update docs for fast-math flags. (details)
  9. [IR] Reimplement FPMathOperator::classof as a whitelist. (details)
  10. [X86] combineX86ShufflesRecursively - pull out (details)
  11. [PGO][PGSO] SizeOpts changes. (details)
  12. [OPENMP50]Add support for master taskloop simd. (details)
  13. gn build: Merge r375254 (details)
  14. [DOCS]Update list of implemented constructs, NFC. (details)
  15. [Format] Add format check for throwing negative numbers (details)
  16. [Reproducer] Use ::rtrim() to remove trailing control characters. (details)
  17. [NFC][CVP] Add @llvm.*.sat tests where we could prove both no-overflows (details)
  18. [Codegen] Link MIRParser into CodeGenTests to fix MachineSizeOptsTest (details)
Commit d5afdbe5a456c055df19421c8d1810d65fbfaeee by jmolloy
[DFAPacketizer] Fix large compile-time regression for VLIW targets
D68992 / rL375086 refactored the packetizer and removed a bunch of
logic. Unfortunately it creates an Automaton object whenever a
DFAPacketizer is required. These objects have no longevity, and in
particular on a debug build the population of the Automaton's transition
map from the underlying table is very slow (because it is called ~10
times per MachineFunction, in the testcase I'm looking at).
This patch changes Automaton to wrap its underlying constant data in
std::shared_ptr, which allows trivial copy construction. The
DFAPacketizer creation function now creates a static archetypical
Automaton and copies that whenever a new DFAPacketizer is required.
This takes a testcase down from ~20s to ~0.5s in debug mode.
llvm-svn: 375240
The file was modifiedllvm/utils/TableGen/DFAPacketizerEmitter.cpp (diff)
The file was modifiedllvm/include/llvm/Support/Automaton.h (diff)
Commit 6c7d7eebda38340d8bbaf99c6ceedb55e32c3a72 by dmitry.preobrazhensky
[AMDGPU][MC][GFX10] Added sdwa/dpp versions of v_cndmask_b32
See https://bugs.llvm.org/show_bug.cgi?id=43608
Reviewers: arsenm, rampitec
Differential Revision: https://reviews.llvm.org/D69096
llvm-svn: 375241
The file was modifiedllvm/test/MC/AMDGPU/wave32.s (diff)
The file was modifiedllvm/lib/Target/AMDGPU/VOP2Instructions.td (diff)
The file was modifiedllvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp (diff)
The file was modifiedllvm/test/MC/Disassembler/AMDGPU/gfx10_dasm_dpp16.txt (diff)
The file was modifiedllvm/test/MC/AMDGPU/gfx10_asm_dpp8.s (diff)
The file was modifiedllvm/test/MC/Disassembler/AMDGPU/wave32.txt (diff)
Commit a50272f8261f775d085524672d33cf67b27cd045 by jotrem
Update MinidumpYAML to use minidump::Exception for exception stream
Reviewers: labath, jhenderson, clayborg, MaskRay, grimar
Reviewed By: grimar
Subscribers: lldb-commits, grimar, MaskRay, hiraditya, llvm-commits
Tags: #llvm, #lldb
Differential Revision: https://reviews.llvm.org/D68657
llvm-svn: 375242
The file was addedllvm/test/tools/yaml2obj/minidump-exception-missing-parameter.yaml
The file was modifiedllvm/include/llvm/ObjectYAML/MinidumpYAML.h (diff)
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-x86_64.yaml (diff)
The file was modifiedllvm/unittests/ObjectYAML/MinidumpYAMLTest.cpp (diff)
The file was modifiedllvm/lib/ObjectYAML/MinidumpEmitter.cpp (diff)
The file was modifiedllvm/test/tools/obj2yaml/basic-minidump.yaml (diff)
The file was modifiedllvm/lib/ObjectYAML/MinidumpYAML.cpp (diff)
Commit d094d97d02232f3c7c5b3b792760cedb5ccac25b by jotrem
LLDB: Use LLVM's type for minidump ExceptionStream [NFC]
Summary: The types defined for it in LLDB are now redundant with core
types.
Reviewers: labath, clayborg
Reviewed By: clayborg
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D68658
llvm-svn: 375243
The file was modifiedlldb/unittests/Process/minidump/MinidumpParserTest.cpp (diff)
The file was modifiedlldb/source/Plugins/Process/minidump/MinidumpTypes.cpp (diff)
The file was modifiedlldb/source/Plugins/Process/minidump/MinidumpParser.h (diff)
The file was modifiedlldb/source/Plugins/Process/minidump/ProcessMinidump.h (diff)
The file was modifiedlldb/source/Plugins/Process/minidump/MinidumpTypes.h (diff)
The file was modifiedlldb/source/Plugins/Process/minidump/MinidumpParser.cpp (diff)
The file was modifiedlldb/source/Plugins/Process/minidump/ProcessMinidump.cpp (diff)
Commit 77460d3888c56a6ed8184783388ed109590ee199 by jotrem
ProcessMinidump: Suppress reporting stop for signal '0'
Summary: The minidump exception stream can report an exception record
with signal 0.  If we try to create a stop reason with signal zero,
processing of the stop event won't find anything, and the debugger will
hang. So, simply early-out of RefreshStateAfterStop in this case.
Also set the UnixSignals object in DoLoadCore as is done for
ProcessElfCore.
Reviewers: labath, clayborg, jfb
Reviewed By: labath, clayborg
Subscribers: dexonsmith, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D68096
llvm-svn: 375244
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py (diff)
The file was addedlldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-x86_64_null_signal.yaml
The file was modifiedlldb/source/Plugins/Process/minidump/ProcessMinidump.cpp (diff)
Commit 7e5d5ee873e14b7e3db0ee07fa402aca13f83a36 by michael.hliao
[tooling] Relax an assert when multiple GPU targets are specified.
llvm-svn: 375245
The file was modifiedclang/lib/Tooling/Tooling.cpp (diff)
Commit eff2a2ab2b51070133c39336c91b3f8d1c31e0c4 by krasimir
[clang-format] fix regression recognizing casts in Obj-C calls
Summary: r373922 added checks for a few tokens that, following an `)`
make it unlikely that the `)` is the closing paren of a cast expression.
The specific check for `tok::l_square` there introduced a regression for
casts of Obj-C calls, like:
```
(cast)[func arg]
``` From the tests added in r373922, I believe the `tok::l_square` case
is added to capture the case where a non-cast `)` is directly followed
by an attribute specifier, like:
``` int f(int x) [[noreturn]];
```
I've specialized the code to look for such attribute specifier instead
of `tok::l_square` in general. Also, I added a regression test and moved
the test cases added in r373922 to an already existing place documenting
other instances of historically misidentified casts.
Reviewers: MyDeveloperDay
Reviewed By: MyDeveloperDay
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69164
llvm-svn: 375247
The file was modifiedclang/unittests/Format/FormatTest.cpp (diff)
The file was modifiedclang/lib/Format/TokenAnnotator.cpp (diff)
Commit aa3806b47c74c814c9cb6f1de6a5570998b8f011 by jay.foad
Update docs for fast-math flags.
This adds fneg, phi and select to the list of operations that may use
fast-math flags.
llvm-svn: 375250
The file was modifiedllvm/docs/LangRef.rst (diff)
Commit a162817a2b7ca0d7bd285a2a3e969a3a652aad57 by jay.foad
[IR] Reimplement FPMathOperator::classof as a whitelist.
Summary: This makes it much easier to verify that the implementation
matches the documentation. It uncovered a bug in the unit tests where we
were accidentally setting fast math flags on a load instruction.
Reviewers: spatel, wristow, arsenm, hfinkel, aemerson, efriedma,
cameron.mcinally, mcberg2017, jmolloy
Subscribers: wdng, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69176
llvm-svn: 375252
The file was modifiedllvm/include/llvm/IR/Operator.h (diff)
The file was modifiedllvm/unittests/IR/IRBuilderTest.cpp (diff)
Commit 696794b66eb29f12a3138a02ef647769bbf9fb38 by llvm-dev
[X86] combineX86ShufflesRecursively - pull out
isTargetShuffleVariableMask. NFCI.
llvm-svn: 375253
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp (diff)
Commit 7e1637451d20d40553165f806094ada30cb0a708 by yamauchi
[PGO][PGSO] SizeOpts changes.
Summary:
(Split of off D67120)
SizeOpts/MachineSizeOpts changes for profile guided size optimization.
Reviewers: davidxl
Subscribers: mgorny, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69070
llvm-svn: 375254
The file was addedllvm/lib/CodeGen/MachineSizeOpts.cpp
The file was modifiedllvm/lib/CodeGen/MachineBlockFrequencyInfo.cpp (diff)
The file was modifiedllvm/unittests/CodeGen/CMakeLists.txt (diff)
The file was modifiedllvm/include/llvm/CodeGen/MachineBlockFrequencyInfo.h (diff)
The file was modifiedllvm/lib/CodeGen/MachineLoopInfo.cpp (diff)
The file was addedllvm/include/llvm/CodeGen/MachineSizeOpts.h
The file was addedllvm/unittests/Transforms/Utils/SizeOptsTest.cpp
The file was modifiedllvm/lib/CodeGen/CMakeLists.txt (diff)
The file was modifiedllvm/lib/CodeGen/MachineDominators.cpp (diff)
The file was modifiedllvm/include/llvm/CodeGen/MachineLoopInfo.h (diff)
The file was modifiedllvm/unittests/Transforms/Utils/CMakeLists.txt (diff)
The file was modifiedllvm/include/llvm/CodeGen/MachineDominators.h (diff)
The file was addedllvm/unittests/CodeGen/MachineSizeOptsTest.cpp
The file was modifiedllvm/include/llvm/Transforms/Utils/SizeOpts.h (diff)
The file was modifiedllvm/lib/Transforms/Utils/SizeOpts.cpp (diff)
Commit b8552abfe7ce0c4cd37d136bbcf8cb319a28f260 by a.bataev
[OPENMP50]Add support for master taskloop simd.
Added  trsing/semantics/codegen for combined construct master taskloop
simd.
llvm-svn: 375255
The file was addedclang/test/OpenMP/master_taskloop_simd_ast_print.cpp
The file was modifiedclang/lib/StaticAnalyzer/Core/ExprEngine.cpp (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_priority_messages.cpp
The file was addedclang/test/OpenMP/master_taskloop_simd_aligned_messages.cpp
The file was addedclang/test/OpenMP/master_taskloop_simd_private_codegen.cpp
The file was addedclang/test/OpenMP/master_taskloop_simd_in_reduction_messages.cpp
The file was addedclang/test/OpenMP/master_taskloop_simd_num_tasks_messages.cpp
The file was modifiedclang/lib/CodeGen/CGStmtOpenMP.cpp (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_misc_messages.c
The file was modifiedclang/include/clang-c/Index.h (diff)
The file was modifiedclang/lib/AST/StmtOpenMP.cpp (diff)
The file was modifiedclang/lib/CodeGen/CGStmt.cpp (diff)
The file was modifiedclang/lib/Serialization/ASTReaderStmt.cpp (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_linear_messages.cpp
The file was addedclang/test/OpenMP/master_taskloop_simd_lastprivate_messages.cpp
The file was modifiedclang/include/clang/Basic/StmtNodes.td (diff)
The file was modifiedclang/lib/Serialization/ASTWriterStmt.cpp (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_grainsize_messages.cpp
The file was addedclang/test/OpenMP/master_taskloop_simd_in_reduction_codegen.cpp
The file was modifiedclang/lib/Parse/ParseOpenMP.cpp (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_collapse_messages.cpp
The file was addedclang/test/OpenMP/master_taskloop_simd_simdlen_messages.cpp
The file was modifiedclang/tools/libclang/CXCursor.cpp (diff)
The file was modifiedclang/lib/AST/StmtPrinter.cpp (diff)
The file was modifiedclang/lib/Sema/TreeTransform.h (diff)
The file was modifiedclang/lib/CodeGen/CGOpenMPRuntime.cpp (diff)
The file was modifiedclang/include/clang/Serialization/ASTBitCodes.h (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_reduction_messages.cpp
The file was modifiedclang/lib/Sema/SemaOpenMP.cpp (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_lastprivate_codegen.cpp
The file was modifiedclang/lib/Basic/OpenMPKinds.cpp (diff)
The file was modifiedclang/lib/AST/StmtProfile.cpp (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_codegen.cpp
The file was addedclang/test/OpenMP/master_taskloop_simd_reduction_codegen.cpp
The file was modifiedclang/tools/libclang/CIndex.cpp (diff)
The file was modifiedclang/include/clang/Basic/OpenMPKinds.def (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_firstprivate_messages.cpp
The file was addedclang/test/OpenMP/master_taskloop_simd_loop_messages.cpp
The file was addedclang/test/OpenMP/master_taskloop_simd_private_messages.cpp
The file was modifiedclang/lib/CodeGen/CodeGenFunction.h (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_final_messages.cpp
The file was modifiedclang/include/clang/Basic/OpenMPKinds.h (diff)
The file was modifiedclang/include/clang/Sema/Sema.h (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_firstprivate_codegen.cpp
The file was modifiedclang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp (diff)
The file was modifiedclang/include/clang/AST/RecursiveASTVisitor.h (diff)
The file was modifiedclang/include/clang/AST/StmtOpenMP.h (diff)
The file was addedclang/test/OpenMP/master_taskloop_simd_safelen_messages.cpp
Commit 52dc406efc717cf5aca1f5ee5600382f348969db by llvmgnsyncbot
gn build: Merge r375254
llvm-svn: 375256
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/Transforms/Utils/BUILD.gn (diff)
The file was modifiedllvm/utils/gn/secondary/llvm/lib/CodeGen/BUILD.gn (diff)
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/CodeGen/BUILD.gn (diff)
Commit 80fe5cffd2eef46ebd19aac6d8c6f2c3f9b4290f by a.bataev
[DOCS]Update list of implemented constructs, NFC.
llvm-svn: 375257
The file was modifiedclang/docs/OpenMPSupport.rst (diff)
Commit 7f704320b058f7217847ee0e599f64e2ce50447c by modocache
[Format] Add format check for throwing negative numbers
Summary: The code `throw -1;` is currently formatted by clang-format as
`throw - 1;`. This diff adds a fix for this edge case and a test to
check for this in the future.
For context, I am looking into a related bug in the clang-formatting of
coroutine keywords: `co_yield -1;` is also reformatted in this manner as
`co_yield - 1;`. A later diff will add these changes and tests for the
`co_yield` and `co_return` keywords.
Patch by Jonathan Thomas (jonathoma)!
Reviewers: modocache, sammccall, Quuxplusone
Reviewed By: sammccall
Subscribers: cfe-commits
Tags: #clang-format, #clang
Differential Revision: https://reviews.llvm.org/D69144
llvm-svn: 375258
The file was modifiedclang/lib/Format/TokenAnnotator.cpp (diff)
The file was modifiedclang/unittests/Format/FormatTest.cpp (diff)
Commit ded44e220f6ce15258663a0353cccc188211f1d7 by Jonas Devlieghere
[Reproducer] Use ::rtrim() to remove trailing control characters.
Pavel correctly pointed out that removing all control characters from
the working directory is overkill. It should be sufficient to just strip
the last ones.
llvm-svn: 375259
The file was modifiedlldb/source/Initialization/SystemInitializerCommon.cpp (diff)
Commit d532f12c82e31ebe260177c0812d20b6a8235272 by lebedev.ri
[NFC][CVP] Add @llvm.*.sat tests where we could prove both no-overflows
llvm-svn: 375260
The file was modifiedllvm/test/Transforms/CorrelatedValuePropagation/overflows.ll (diff)
Commit 9a055dc19163b5e9eaa0dde6869502fd33b4f44e by lebedev.ri
[Codegen] Link MIRParser into CodeGenTests to fix MachineSizeOptsTest
building
llvm-svn: 375261
The file was modifiedllvm/unittests/CodeGen/CMakeLists.txt (diff)