FailedChanges

Summary

  1. [clangd] Express dumpAST in tests as a customAction() (details)
  2. Revert "[BPI] Improve static heuristics for integer comparisons" (details)
  3. [libc++] Use CMake interface targets to setup benchmark flags (details)
  4. Support the standards-based dates for __has_c_attribute (details)
  5. [libc++][test] Fix -Wstring-concatenation warnings (details)
  6. [AMDGPU] Fix missed SI_RETURN_TO_EPILOG in pre-emit peephole (details)
  7. Introduce ns_error_domain attribute. (details)
  8. [InstCombine] Fix incorrect Modified status (details)
  9. [NFC] Add test case showing the miscompile being fixed by D83507 (details)
  10. [SyntaxTree] Split `TreeTest.cpp` (details)
  11. [SyntaxTree] Clean `#includes` in `TreeTestBase.h` (details)
  12. DAG: Don't pass 0 alignment value to allowsMisalignedMemoryAccesses (details)
  13. [gn build] Port d17437d2bd8 (details)
  14. [MLIR] Support for ReturnOps in memref map layout normalization (details)
  15. [libc++][test] Fix another -Wstring-concatenation warning (details)
  16. [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations (details)
  17. clang: Fix minor grammar-o in diag added in c354b2e3b (details)
  18. rG9bd97d0363987b582 - Revert "[X86][SSE] Fold HOP(SHUFFLE(X),SHUFFLE(Y)) --> SHUFFLE(HOP(X,Y))" (details)
  19. Fix unused variable warning. NFC. (details)
  20. [analyzer] Fix crash with pointer to members values (details)
  21. [clangd] Revert "[clangd] Fix crash-bug in preamble indexing when using modules." (details)
  22. [libc++] Ensure the CI scripts can find Ninja (details)
  23. [llvm-objdump] Change symbol name/PLT decoding errors to warnings (details)
Commit 41d0edd54e29e994fa7d40961a38e8fca27addac by sam.mccall
[clangd] Express dumpAST in tests as a customAction()
The file was modifiedclang-tools-extra/clangd/ParsedAST.cpp
The file was modifiedclang-tools-extra/clangd/unittests/SyncAPI.h
The file was modifiedclang-tools-extra/clangd/ClangdServer.cpp
The file was modifiedclang-tools-extra/clangd/unittests/ClangdTests.cpp
The file was modifiedclang-tools-extra/clangd/ParsedAST.h
The file was modifiedclang-tools-extra/clangd/unittests/SyncAPI.cpp
The file was modifiedclang-tools-extra/clangd/ClangdServer.h
Commit f9264995a6911abc208f0a0c1e0272fe5fbcbec9 by Dávid Bolvanský
Revert "[BPI] Improve static heuristics for integer comparisons"

This reverts commit 44587e2f7e732604cd6340061d40ac21e7e188e5. Sanitizer tests need to be updated.
The file was modifiedllvm/test/CodeGen/X86/memcmp-pgso.ll
The file was modifiedllvm/test/CodeGen/Mips/lcb2.ll
The file was modifiedllvm/test/CodeGen/X86/machine-cse.ll
The file was modifiedllvm/test/CodeGen/X86/atomic-unordered.ll
The file was modifiedllvm/lib/Analysis/BranchProbabilityInfo.cpp
The file was modifiedllvm/test/Analysis/BranchProbabilityInfo/loop.ll
The file was modifiedllvm/test/CodeGen/X86/memcmp-optsize.ll
The file was modifiedllvm/test/CodeGen/X86/bt.ll
The file was modifiedllvm/test/CodeGen/ARM/lsr-unfolded-offset.ll
The file was modifiedllvm/include/llvm/Analysis/BranchProbabilityInfo.h
The file was modifiedllvm/test/CodeGen/X86/neg_cmp.ll
The file was modifiedllvm/test/CodeGen/Mips/brconne.ll
The file was modifiedllvm/test/CodeGen/PowerPC/brcond.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-postinc-distribute.ll
The file was modifiedllvm/test/CodeGen/Thumb2/thumb2-branch.ll
The file was modifiedllvm/test/Transforms/PGOProfile/counter_promo_mexits.ll
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/mve-float-loops.ll
The file was modifiedllvm/test/CodeGen/AArch64/branch-relax-alignment.ll
The file was modifiedllvm/test/CodeGen/X86/memcmp.ll
The file was modifiedllvm/test/CodeGen/X86/bmi.ll
The file was modifiedllvm/test/CodeGen/X86/jump_sign.ll
The file was modifiedllvm/test/CodeGen/Mips/selle.ll
The file was modifiedllvm/test/CodeGen/ARM/machine-cse-cmp.ll
The file was modifiedllvm/test/CodeGen/RISCV/branch.ll
The file was modifiedllvm/test/CodeGen/X86/atomic-flags.ll
The file was modifiedllvm/test/CodeGen/X86/funnel-shift.ll
The file was modifiedllvm/test/CodeGen/X86/fast-isel-cmp-branch2.ll
The file was modifiedllvm/test/CodeGen/Mips/brconlt.ll
The file was modifiedllvm/test/Transforms/PGOProfile/landingpad.ll
The file was modifiedllvm/test/CodeGen/Mips/compactbranches/no-beqzc-bnezc.ll
The file was modifiedllvm/test/CodeGen/AArch64/fast-isel-cmp-branch.ll
The file was modifiedllvm/test/CodeGen/SystemZ/int-cmp-40.ll
The file was modifiedllvm/test/CodeGen/Mips/seleq.ll
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/varying-outer-2d-reduction.ll
The file was modifiedllvm/test/CodeGen/X86/wide-integer-cmp.ll
The file was modifiedllvm/test/CodeGen/AArch64/combine-comparisons-by-cse.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-satmul-loops.ll
The file was modifiedllvm/test/CodeGen/PowerPC/redundant-copy-after-tail-dup.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-postinc-lsr.ll
The file was modifiedllvm/test/CodeGen/X86/conditional-tailcall.ll
The file was modifiedllvm/test/DebugInfo/COFF/fpo-shrink-wrap.ll
The file was modifiedllvm/test/CodeGen/ARM/cmpxchg-weak.ll
The file was modifiedllvm/test/CodeGen/AArch64/aarch64-gep-opt.ll
The file was removedllvm/test/Analysis/BranchProbabilityInfo/integer_heuristics.ll
The file was modifiedllvm/test/CodeGen/Mips/brcongt.ll
The file was modifiedllvm/test/CodeGen/X86/pr29170.ll
The file was modifiedllvm/test/CodeGen/PowerPC/memCmpUsedInZeroEqualityComparison.ll
The file was addedllvm/test/Analysis/BranchProbabilityInfo/zero_heuristics.ll
The file was modifiedllvm/test/CodeGen/AArch64/cond-br-tuning.ll
The file was modifiedllvm/test/CodeGen/SystemZ/int-cmp-37.ll
The file was modifiedllvm/test/CodeGen/X86/lsr-negative-stride.ll
The file was modifiedllvm/test/CodeGen/RISCV/rv64m-w-insts-legalization.ll
The file was modifiedllvm/test/CodeGen/Mips/lcb5.ll
The file was modifiedllvm/test/CodeGen/X86/conditional-tailcall-pgso.ll
The file was modifiedllvm/test/CodeGen/X86/absolute-cmp.ll
The file was modifiedllvm/test/CodeGen/Mips/longbranch/compact-branches-long-branch.ll
The file was modifiedllvm/test/CodeGen/X86/indirect-branch-tracking-eh2.ll
The file was modifiedllvm/test/CodeGen/ARM/2011-12-14-machine-sink.ll
The file was modifiedllvm/test/CodeGen/Hexagon/newvaluejump2.ll
The file was modifiedllvm/test/CodeGen/X86/3addr-16bit.ll
The file was modifiedllvm/test/CodeGen/X86/memcmp-more-load-pairs.ll
The file was modifiedllvm/test/CodeGen/X86/nobt.ll
Commit da0592e4c8df95efad4e42d63646f8a5336a7edc by Louis Dionne
[libc++] Use CMake interface targets to setup benchmark flags

This also fixes an issue where the benchmarks were being built with C++14
instead of C++17, as they should be.
The file was modifiedlibcxx/benchmarks/CMakeLists.txt
Commit 9936b96d5333af4e6dff55025943366bb5f07272 by aaron
Support the standards-based dates for __has_c_attribute

WG14 N2481 was adopted with minor modifications at the latest WG14 meetings.
The only modification to the paper was to correct the date for the deprecated
attribute to be 201904L (the corrected date value will be present in WG14
N2553 when it gets published).
The file was modifiedclang/utils/TableGen/ClangAttrEmitter.cpp
The file was modifiedclang/test/Preprocessor/has_c_attribute.c
The file was modifiedclang/include/clang/Basic/Attr.td
Commit c58f1fe2aebffaf6069b9f43940eebee183da687 by Louis Dionne
[libc++][test] Fix -Wstring-concatenation warnings
The file was modifiedlibcxx/test/std/input.output/filesystems/class.path/path.member/path.compare.pass.cpp
The file was modifiedlibcxx/test/libcxx/utilities/function.objects/unord.hash/murmur2_or_cityhash_ubsan_unsigned_overflow_ignored.pass.cpp
Commit d538c5837a2cfedbf274133e29612da76003beed by carl.ritson
[AMDGPU] Fix missed SI_RETURN_TO_EPILOG in pre-emit peephole

SIPreEmitPeephole does not process all terminators, which means
it can fail to handle SI_RETURN_TO_EPILOG if immediately preceeded
by a branch to the early exit block.

Reviewed By: rampitec

Differential Revision: https://reviews.llvm.org/D85872
The file was modifiedllvm/lib/Target/AMDGPU/SIPreEmitPeephole.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/transform-block-with-return-to-epilog.ll
Commit a5b8757506b07e3091fe243b6c1e004220d3cba3 by gribozavr
Introduce ns_error_domain attribute.

ns_error_domain can be used by, e.g. NS_ERROR_ENUM, in order to
identify a global declaration representing the domain constant.

Introduces the attribute, Sema handling, diagnostics, and test case.

This is cherry-picked from https://github.com/llvm/llvm-project-staging/commit/a14779f504b02ad0e4dbc39d6d10cadc7ed4cfd0
and adapted to updated Clang APIs.

Reviewed By: gribozavr2, aaron.ballman

Differential Revision: https://reviews.llvm.org/D84005
The file was modifiedclang/include/clang/Basic/Attr.td
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was modifiedclang/lib/Sema/SemaDeclAttr.cpp
The file was modifiedclang/utils/TableGen/ClangAttrEmitter.cpp
The file was modifiedclang/test/AST/ast-print-attr.c
The file was modifiedclang/test/Misc/pragma-attribute-supported-attributes-list.test
The file was addedclang/test/Sema/ns_error_enum.m
The file was modifiedclang/include/clang/Basic/AttrDocs.td
Commit e8ebebb0bde602199c4012efbcfe823f7ab9337f by david.stenberg
[InstCombine] Fix incorrect Modified status

When removing instructions from unreachable blocks, and only debug info
intrinsics were removed, InstCombine could incorrectly return a false
Modified status.

This is fixed by making removeAllNonTerminatorAndEHPadInstructions()
also return how many debug info intrinsics that were removed, and take
that into account.

This was caught using the check introduced by D80916.

Reviewed By: majnemer

Differential Revision: https://reviews.llvm.org/D85839
The file was modifiedllvm/lib/Transforms/InstCombine/InstructionCombining.cpp
The file was addedllvm/test/Transforms/InstCombine/unreachable-dbg-info-modified.ll
The file was modifiedllvm/lib/Transforms/Scalar/SCCP.cpp
The file was modifiedllvm/lib/Transforms/Utils/Local.cpp
The file was modifiedllvm/include/llvm/Transforms/Utils/Local.h
Commit 3bd2513ebd788a48394ababbc62b5cdcfa3dde12 by lebedev.ri
[NFC] Add test case showing the miscompile being fixed by D83507

See https://reviews.llvm.org/D83507
The file was addedllvm/test/Transforms/PhaseOrdering/d83507-knowledge-retention-bug.ll
Commit d17437d2bd8e83baee96f2860276d615d216dfbc by ecaldas
[SyntaxTree] Split `TreeTest.cpp`

We extract the test infrastructure into `TreeTestBase.h` and split the
tests into `MutationsTest.cpp` and `BuildTreeTest.cpp`
The file was modifiedclang/unittests/Tooling/Syntax/CMakeLists.txt
The file was removedclang/unittests/Tooling/Syntax/TreeTest.cpp
The file was addedclang/unittests/Tooling/Syntax/BuildTreeTest.cpp
The file was addedclang/unittests/Tooling/Syntax/TreeTestBase.h
The file was addedclang/unittests/Tooling/Syntax/MutationsTest.cpp
Commit 9c2e708f0dc547d386ea528450a33ef4bd2a750b by ecaldas
[SyntaxTree] Clean `#includes` in `TreeTestBase.h`

Differential Revision: https://reviews.llvm.org/D85898
The file was modifiedclang/unittests/Tooling/Syntax/MutationsTest.cpp
The file was modifiedclang/unittests/Tooling/Syntax/TreeTestBase.h
Commit c7191e318544ea0c30b5678c1f2e79e0c5be9628 by Matthew.Arsenault
DAG: Don't pass 0 alignment value to allowsMisalignedMemoryAccesses

I think not unconditionally passing getDstAlign is broken, but leave
that for another change.
The file was addedllvm/test/CodeGen/AMDGPU/memcpy-fixed-align.ll
The file was modifiedllvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
Commit fc7f004b887594ed9b5e25497aa4475b3e74cc94 by llvmgnsyncbot
[gn build] Port d17437d2bd8
The file was modifiedllvm/utils/gn/secondary/clang/unittests/Tooling/Syntax/BUILD.gn
Commit 6d4f7801b1d2a0ec6fbc0cb4eb9d3613df788d78 by uday
[MLIR] Support for ReturnOps in memref map layout normalization

-- This commit handles the returnOp in memref map layout normalization.
-- An initial filter is applied on FuncOps which helps us know which functions can be
   a suitable candidate for memref normalization which doesn't lead to invalid IR.
-- Handles memref map normalization for external function assuming the external function
   is normalizable.

Differential Revision: https://reviews.llvm.org/D85226
The file was modifiedmlir/lib/Transforms/NormalizeMemRefs.cpp
The file was modifiedmlir/lib/Transforms/Utils/Utils.cpp
The file was modifiedmlir/test/Transforms/normalize-memrefs.mlir
Commit 2916dd5669e7700eff41c891916d6030511cef3e by Louis Dionne
[libc++][test] Fix another -Wstring-concatenation warning
The file was modifiedlibcxx/test/libcxx/fuzzing/partial_sort.pass.cpp
Commit 4225e7fa34febac6da8c9151bd69f998a6a1d7df by clementval
[mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations

This patch introduces the OpenACC dialect with three operation defined
parallel, data and loop operations with custom parsing and printing.

OpenACC dialect RFC can be find here: https://llvm.discourse.group/t/rfc-openacc-dialect/546/2

Reviewed By: rriddle, kiranchandramohan

Differential Revision: https://reviews.llvm.org/D84268
The file was modifiedmlir/include/mlir/InitAllDialects.h
The file was addedmlir/include/mlir/Dialect/OpenACC/CMakeLists.txt
The file was modifiedmlir/include/mlir/Dialect/CMakeLists.txt
The file was modifiedmlir/lib/Dialect/CMakeLists.txt
The file was addedmlir/test/Dialect/OpenACC/ops.mlir
The file was addedmlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
The file was addedmlir/lib/Dialect/OpenACC/CMakeLists.txt
The file was addedmlir/include/mlir/Dialect/OpenACC/OpenACC.h
The file was modifiedmlir/include/mlir/IR/DialectSymbolRegistry.def
The file was addedmlir/include/mlir/Dialect/OpenACC/OpenACCOps.td
Commit 82057e3f39e624dbaa5bbd7497c359f704347f6f by thakis
clang: Fix minor grammar-o in diag added in c354b2e3b
The file was modifiedclang/test/Modules/namespaces.cpp
The file was modifiedclang/test/SemaCXX/elaborated-type-specifier.cpp
The file was modifiedclang/test/SemaCXX/pointer-forward-declared-class-conversion.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
Commit cd3b850a4c8eb7871f2cefb47b1274e734ad92f6 by llvm-dev
rG9bd97d0363987b582 - Revert "[X86][SSE] Fold HOP(SHUFFLE(X),SHUFFLE(Y)) --> SHUFFLE(HOP(X,Y))"

This reverts commit 9bd97d0363987b582e4a92b354b02e86ac068407.

Seeing some codegen issues in internal testing.
The file was modifiedllvm/test/CodeGen/X86/haddsub-shuf.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/X86/haddsub-undef.ll
Commit 63863451d18b3ef590cba9916e1bec181ad252e7 by llvm-dev
Fix unused variable warning. NFC.

Reduce the dyn_cast<> to a isa<> as that's all non-assert builds require, and move the cast<> inside the assert.
The file was modifiedllvm/lib/Analysis/LazyValueInfo.cpp
Commit 9cbfdde2ea060d7e51fd2637f63eaa74b8d92848 by vsavchenko
[analyzer] Fix crash with pointer to members values

This fix unifies all of the different ways we handled pointer to
members into one.  The crash was caused by the fact that the type
of pointer-to-member values was `void *`, and while this works
for the vast majority of cases it breaks when we actually need
to explain the path for the report.

rdar://problem/64202361

Differential Revision: https://reviews.llvm.org/D85817
The file was modifiedclang/lib/StaticAnalyzer/Core/SValBuilder.cpp
The file was modifiedclang/test/Analysis/pointer-to-member.cpp
The file was modifiedclang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h
The file was modifiedclang/lib/StaticAnalyzer/Core/ExprEngine.cpp
The file was modifiedclang/lib/StaticAnalyzer/Core/ExprEngineC.cpp
The file was modifiedclang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
The file was modifiedclang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h
The file was modifiedclang/lib/StaticAnalyzer/Core/SVals.cpp
The file was addedclang/test/Analysis/PR46264.cpp
The file was modifiedclang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp
The file was modifiedclang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h
Commit 73f0772c0baf1c7cac2995341c11d83c4d7a37f4 by adamcz
[clangd] Revert "[clangd] Fix crash-bug in preamble indexing when using modules."

This reverts commit 4061d9e42cff621462931ac7df9666806c77a237.
Tests are failing in some configuration, likely due to not cleaning up
module cache path before running the test.

Differential Revision: https://reviews.llvm.org/D85907
The file was modifiedclang/lib/Index/IndexingAction.cpp
The file was modifiedclang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/TestFS.h
The file was modifiedclang-tools-extra/clangd/unittests/TestTU.cpp
The file was modifiedclang-tools-extra/clangd/unittests/TestTU.h
Commit 1ffc299628948ee0bee3ffb7451c9085b5a80e83 by Louis Dionne
[libc++] Ensure the CI scripts can find Ninja

Ninja isn't necessarily installed on macOS out of the box, so make sure
we use the SDK Ninja instead of relying on one being available on the
system.
The file was modifiedlibcxx/utils/ci/macos-backdeployment.sh
The file was modifiedlibcxx/utils/ci/macos-trunk.sh
Commit 7f8c49b016003a1a642235b14788648736809a58 by i
[llvm-objdump] Change symbol name/PLT decoding errors to warnings

If the referenced symbol of a J[U]MP_SLOT is invalid (e.g. symbol index 0), llvm-objdump -d will bail out:

```
error: 'a': st_name (0x326600) is past the end of the string table of size 0x7
```

where 0x326600 is the st_name field of the first entry past the end of .symtab

Change it to a warning to continue dumping.
`X86/plt.test` uses a prebuilt executable, so I pick `ELF/AArch64/plt.test`
which has a YAML input and can be easily modified.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D85623
The file was modifiedllvm/lib/Object/ELFObjectFile.cpp
The file was modifiedllvm/test/tools/llvm-objdump/ELF/AArch64/plt.test
The file was modifiedllvm/include/llvm/Object/ELFObjectFile.h
The file was modifiedllvm/tools/llvm-objdump/llvm-objdump.cpp
The file was modifiedllvm/test/tools/llvm-objdump/MachO/malformed-machos.test
The file was modifiedllvm/tools/llvm-cfi-verify/lib/FileAnalysis.cpp