/Users/buildslave/jenkins/workspace/coverage/llvm-project/clang/lib/StaticAnalyzer/Core/ExprEngineObjC.cpp
Line | Count | Source (jump to first uncovered line) |
1 | | //=-- ExprEngineObjC.cpp - ExprEngine support for Objective-C ---*- C++ -*-===// |
2 | | // |
3 | | // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. |
4 | | // See https://llvm.org/LICENSE.txt for license information. |
5 | | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
6 | | // |
7 | | //===----------------------------------------------------------------------===// |
8 | | // |
9 | | // This file defines ExprEngine's support for Objective-C expressions. |
10 | | // |
11 | | //===----------------------------------------------------------------------===// |
12 | | |
13 | | #include "clang/AST/StmtObjC.h" |
14 | | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
15 | | #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" |
16 | | #include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h" |
17 | | |
18 | | using namespace clang; |
19 | | using namespace ento; |
20 | | |
21 | | void ExprEngine::VisitLvalObjCIvarRefExpr(const ObjCIvarRefExpr *Ex, |
22 | | ExplodedNode *Pred, |
23 | 1.06k | ExplodedNodeSet &Dst) { |
24 | 1.06k | ProgramStateRef state = Pred->getState(); |
25 | 1.06k | const LocationContext *LCtx = Pred->getLocationContext(); |
26 | 1.06k | SVal baseVal = state->getSVal(Ex->getBase(), LCtx); |
27 | 1.06k | SVal location = state->getLValue(Ex->getDecl(), baseVal); |
28 | | |
29 | 1.06k | ExplodedNodeSet dstIvar; |
30 | 1.06k | StmtNodeBuilder Bldr(Pred, dstIvar, *currBldrCtx); |
31 | 1.06k | Bldr.generateNode(Ex, Pred, state->BindExpr(Ex, LCtx, location)); |
32 | | |
33 | | // Perform the post-condition check of the ObjCIvarRefExpr and store |
34 | | // the created nodes in 'Dst'. |
35 | 1.06k | getCheckerManager().runCheckersForPostStmt(Dst, dstIvar, Ex, *this); |
36 | 1.06k | } |
37 | | |
38 | | void ExprEngine::VisitObjCAtSynchronizedStmt(const ObjCAtSynchronizedStmt *S, |
39 | | ExplodedNode *Pred, |
40 | 19 | ExplodedNodeSet &Dst) { |
41 | 19 | getCheckerManager().runCheckersForPreStmt(Dst, Pred, S, *this); |
42 | 19 | } |
43 | | |
44 | | /// Generate a node in \p Bldr for an iteration statement using ObjC |
45 | | /// for-loop iterator. |
46 | | static void populateObjCForDestinationSet( |
47 | | ExplodedNodeSet &dstLocation, SValBuilder &svalBuilder, |
48 | | const ObjCForCollectionStmt *S, const Stmt *elem, SVal elementV, |
49 | | SymbolManager &SymMgr, const NodeBuilderContext *currBldrCtx, |
50 | 517 | StmtNodeBuilder &Bldr, bool hasElements) { |
51 | | |
52 | 517 | for (ExplodedNode *Pred : dstLocation) { |
53 | 517 | ProgramStateRef state = Pred->getState(); |
54 | 517 | const LocationContext *LCtx = Pred->getLocationContext(); |
55 | | |
56 | 517 | ProgramStateRef nextState = |
57 | 517 | ExprEngine::setWhetherHasMoreIteration(state, S, LCtx, hasElements); |
58 | | |
59 | 517 | if (auto MV = elementV.getAs<loc::MemRegionVal>()) |
60 | 517 | if (const auto *R = dyn_cast<TypedValueRegion>(MV->getRegion())) { |
61 | | // FIXME: The proper thing to do is to really iterate over the |
62 | | // container. We will do this with dispatch logic to the store. |
63 | | // For now, just 'conjure' up a symbolic value. |
64 | 517 | QualType T = R->getValueType(); |
65 | 517 | assert(Loc::isLocType(T)); |
66 | | |
67 | 517 | SVal V; |
68 | 517 | if (hasElements) { |
69 | 257 | SymbolRef Sym = SymMgr.conjureSymbol(elem, LCtx, T, |
70 | 257 | currBldrCtx->blockCount()); |
71 | 257 | V = svalBuilder.makeLoc(Sym); |
72 | 260 | } else { |
73 | 260 | V = svalBuilder.makeIntVal(0, T); |
74 | 260 | } |
75 | | |
76 | 517 | nextState = nextState->bindLoc(elementV, V, LCtx); |
77 | 517 | } |
78 | | |
79 | 517 | Bldr.generateNode(S, Pred, nextState); |
80 | 517 | } |
81 | 517 | } |
82 | | |
83 | | void ExprEngine::VisitObjCForCollectionStmt(const ObjCForCollectionStmt *S, |
84 | | ExplodedNode *Pred, |
85 | 260 | ExplodedNodeSet &Dst) { |
86 | | |
87 | | // ObjCForCollectionStmts are processed in two places. This method |
88 | | // handles the case where an ObjCForCollectionStmt* occurs as one of the |
89 | | // statements within a basic block. This transfer function does two things: |
90 | | // |
91 | | // (1) binds the next container value to 'element'. This creates a new |
92 | | // node in the ExplodedGraph. |
93 | | // |
94 | | // (2) note whether the collection has any more elements (or in other words, |
95 | | // whether the loop has more iterations). This will be tested in |
96 | | // processBranch. |
97 | | // |
98 | | // FIXME: Eventually this logic should actually do dispatches to |
99 | | // 'countByEnumeratingWithState:objects:count:' (NSFastEnumeration). |
100 | | // This will require simulating a temporary NSFastEnumerationState, either |
101 | | // through an SVal or through the use of MemRegions. This value can |
102 | | // be affixed to the ObjCForCollectionStmt* instead of 0/1; when the loop |
103 | | // terminates we reclaim the temporary (it goes out of scope) and we |
104 | | // we can test if the SVal is 0 or if the MemRegion is null (depending |
105 | | // on what approach we take). |
106 | | // |
107 | | // For now: simulate (1) by assigning either a symbol or nil if the |
108 | | // container is empty. Thus this transfer function will by default |
109 | | // result in state splitting. |
110 | | |
111 | 260 | const Stmt *elem = S->getElement(); |
112 | 260 | const Stmt *collection = S->getCollection(); |
113 | 260 | ProgramStateRef state = Pred->getState(); |
114 | 260 | SVal collectionV = state->getSVal(collection, Pred->getLocationContext()); |
115 | | |
116 | 260 | SVal elementV; |
117 | 260 | if (const auto *DS = dyn_cast<DeclStmt>(elem)) { |
118 | 127 | const VarDecl *elemD = cast<VarDecl>(DS->getSingleDecl()); |
119 | 127 | assert(elemD->getInit() == nullptr); |
120 | 127 | elementV = state->getLValue(elemD, Pred->getLocationContext()); |
121 | 133 | } else { |
122 | 133 | elementV = state->getSVal(elem, Pred->getLocationContext()); |
123 | 133 | } |
124 | | |
125 | 260 | bool isContainerNull = state->isNull(collectionV).isConstrainedTrue(); |
126 | | |
127 | 260 | ExplodedNodeSet dstLocation; |
128 | 260 | evalLocation(dstLocation, S, elem, Pred, state, elementV, false); |
129 | | |
130 | 260 | ExplodedNodeSet Tmp; |
131 | 260 | StmtNodeBuilder Bldr(Pred, Tmp, *currBldrCtx); |
132 | | |
133 | 260 | if (!isContainerNull) |
134 | 257 | populateObjCForDestinationSet(dstLocation, svalBuilder, S, elem, elementV, |
135 | 257 | SymMgr, currBldrCtx, Bldr, |
136 | 257 | /*hasElements=*/true); |
137 | | |
138 | 260 | populateObjCForDestinationSet(dstLocation, svalBuilder, S, elem, elementV, |
139 | 260 | SymMgr, currBldrCtx, Bldr, |
140 | 260 | /*hasElements=*/false); |
141 | | |
142 | | // Finally, run any custom checkers. |
143 | | // FIXME: Eventually all pre- and post-checks should live in VisitStmt. |
144 | 260 | getCheckerManager().runCheckersForPostStmt(Dst, Tmp, S, *this); |
145 | 260 | } |
146 | | |
147 | | void ExprEngine::VisitObjCMessage(const ObjCMessageExpr *ME, |
148 | | ExplodedNode *Pred, |
149 | 4.39k | ExplodedNodeSet &Dst) { |
150 | 4.39k | CallEventManager &CEMgr = getStateManager().getCallEventManager(); |
151 | 4.39k | CallEventRef<ObjCMethodCall> Msg = CEMgr.getObjCMethodCall( |
152 | 4.39k | ME, Pred->getState(), Pred->getLocationContext(), getCFGElementRef()); |
153 | | |
154 | | // There are three cases for the receiver: |
155 | | // (1) it is definitely nil, |
156 | | // (2) it is definitely non-nil, and |
157 | | // (3) we don't know. |
158 | | // |
159 | | // If the receiver is definitely nil, we skip the pre/post callbacks and |
160 | | // instead call the ObjCMessageNil callbacks and return. |
161 | | // |
162 | | // If the receiver is definitely non-nil, we call the pre- callbacks, |
163 | | // evaluate the call, and call the post- callbacks. |
164 | | // |
165 | | // If we don't know, we drop the potential nil flow and instead |
166 | | // continue from the assumed non-nil state as in (2). This approach |
167 | | // intentionally drops coverage in order to prevent false alarms |
168 | | // in the following scenario: |
169 | | // |
170 | | // id result = [o someMethod] |
171 | | // if (result) { |
172 | | // if (!o) { |
173 | | // // <-- This program point should be unreachable because if o is nil |
174 | | // // it must the case that result is nil as well. |
175 | | // } |
176 | | // } |
177 | | // |
178 | | // However, it also loses coverage of the nil path prematurely, |
179 | | // leading to missed reports. |
180 | | // |
181 | | // It's possible to handle this by performing a state split on every call: |
182 | | // explore the state where the receiver is non-nil, and independently |
183 | | // explore the state where it's nil. But this is not only slow, but |
184 | | // completely unwarranted. The mere presence of the message syntax in the code |
185 | | // isn't sufficient evidence that nil is a realistic possibility. |
186 | | // |
187 | | // An ideal solution would be to add the following constraint that captures |
188 | | // both possibilities without splitting the state: |
189 | | // |
190 | | // ($x == 0) => ($y == 0) (1) |
191 | | // |
192 | | // where in our case '$x' is the receiver symbol, '$y' is the returned symbol, |
193 | | // and '=>' is logical implication. But RangeConstraintManager can't handle |
194 | | // such constraints yet, so for now we go with a simpler, more restrictive |
195 | | // constraint: $x != 0, from which (1) follows as a vacuous truth. |
196 | 4.39k | if (Msg->isInstanceMessage()) { |
197 | 3.36k | SVal recVal = Msg->getReceiverSVal(); |
198 | 3.36k | if (!recVal.isUndef()) { |
199 | | // Bifurcate the state into nil and non-nil ones. |
200 | 3.35k | DefinedOrUnknownSVal receiverVal = |
201 | 3.35k | recVal.castAs<DefinedOrUnknownSVal>(); |
202 | 3.35k | ProgramStateRef State = Pred->getState(); |
203 | | |
204 | 3.35k | ProgramStateRef notNilState, nilState; |
205 | 3.35k | std::tie(notNilState, nilState) = State->assume(receiverVal); |
206 | | |
207 | | // Receiver is definitely nil, so run ObjCMessageNil callbacks and return. |
208 | 3.35k | if (nilState && !notNilState1.96k ) { |
209 | 96 | ExplodedNodeSet dstNil; |
210 | 96 | StmtNodeBuilder Bldr(Pred, dstNil, *currBldrCtx); |
211 | 96 | bool HasTag = Pred->getLocation().getTag(); |
212 | 96 | Pred = Bldr.generateNode(ME, Pred, nilState, nullptr, |
213 | 96 | ProgramPoint::PreStmtKind); |
214 | 96 | assert((Pred || HasTag) && "Should have cached out already!"); |
215 | 96 | (void)HasTag; |
216 | 96 | if (!Pred) |
217 | 0 | return; |
218 | | |
219 | 96 | ExplodedNodeSet dstPostCheckers; |
220 | 96 | getCheckerManager().runCheckersForObjCMessageNil(dstPostCheckers, Pred, |
221 | 96 | *Msg, *this); |
222 | 96 | for (auto *I : dstPostCheckers) |
223 | 89 | finishArgumentConstruction(Dst, I, *Msg); |
224 | 96 | return; |
225 | 96 | } |
226 | | |
227 | 3.25k | ExplodedNodeSet dstNonNil; |
228 | 3.25k | StmtNodeBuilder Bldr(Pred, dstNonNil, *currBldrCtx); |
229 | | // Generate a transition to the non-nil state, dropping any potential |
230 | | // nil flow. |
231 | 3.25k | if (notNilState != State) { |
232 | 1.86k | bool HasTag = Pred->getLocation().getTag(); |
233 | 1.86k | Pred = Bldr.generateNode(ME, Pred, notNilState); |
234 | 1.86k | assert((Pred || HasTag) && "Should have cached out already!"); |
235 | 1.86k | (void)HasTag; |
236 | 1.86k | if (!Pred) |
237 | 0 | return; |
238 | 1.86k | } |
239 | 3.25k | } |
240 | 3.36k | } |
241 | | |
242 | | // Handle the previsits checks. |
243 | 4.29k | ExplodedNodeSet dstPrevisit; |
244 | 4.29k | getCheckerManager().runCheckersForPreObjCMessage(dstPrevisit, Pred, |
245 | 4.29k | *Msg, *this); |
246 | 4.29k | ExplodedNodeSet dstGenericPrevisit; |
247 | 4.29k | getCheckerManager().runCheckersForPreCall(dstGenericPrevisit, dstPrevisit, |
248 | 4.29k | *Msg, *this); |
249 | | |
250 | | // Proceed with evaluate the message expression. |
251 | 4.29k | ExplodedNodeSet dstEval; |
252 | 4.29k | StmtNodeBuilder Bldr(dstGenericPrevisit, dstEval, *currBldrCtx); |
253 | | |
254 | 4.29k | for (ExplodedNodeSet::iterator DI = dstGenericPrevisit.begin(), |
255 | 8.51k | DE = dstGenericPrevisit.end(); DI != DE; ++DI4.21k ) { |
256 | 4.21k | ExplodedNode *Pred = *DI; |
257 | 4.21k | ProgramStateRef State = Pred->getState(); |
258 | 4.21k | CallEventRef<ObjCMethodCall> UpdatedMsg = Msg.cloneWithState(State); |
259 | | |
260 | 4.21k | if (UpdatedMsg->isInstanceMessage()) { |
261 | 3.18k | SVal recVal = UpdatedMsg->getReceiverSVal(); |
262 | 3.18k | if (!recVal.isUndef()) { |
263 | 3.18k | if (ObjCNoRet.isImplicitNoReturn(ME)) { |
264 | | // If we raise an exception, for now treat it as a sink. |
265 | | // Eventually we will want to handle exceptions properly. |
266 | 2 | Bldr.generateSink(ME, Pred, State); |
267 | 2 | continue; |
268 | 2 | } |
269 | 3.18k | } |
270 | 3.18k | } else { |
271 | | // Check for special class methods that are known to not return |
272 | | // and that we should treat as a sink. |
273 | 1.02k | if (ObjCNoRet.isImplicitNoReturn(ME)) { |
274 | | // If we raise an exception, for now treat it as a sink. |
275 | | // Eventually we will want to handle exceptions properly. |
276 | 5 | Bldr.generateSink(ME, Pred, Pred->getState()); |
277 | 5 | continue; |
278 | 5 | } |
279 | 1.02k | } |
280 | | |
281 | 4.20k | defaultEvalCall(Bldr, Pred, *UpdatedMsg); |
282 | 4.20k | } |
283 | | |
284 | | // If there were constructors called for object-type arguments, clean them up. |
285 | 4.29k | ExplodedNodeSet dstArgCleanup; |
286 | 4.29k | for (auto *I : dstEval) |
287 | 3.62k | finishArgumentConstruction(dstArgCleanup, I, *Msg); |
288 | | |
289 | 4.29k | ExplodedNodeSet dstPostvisit; |
290 | 4.29k | getCheckerManager().runCheckersForPostCall(dstPostvisit, dstArgCleanup, |
291 | 4.29k | *Msg, *this); |
292 | | |
293 | | // Finally, perform the post-condition check of the ObjCMessageExpr and store |
294 | | // the created nodes in 'Dst'. |
295 | 4.29k | getCheckerManager().runCheckersForPostObjCMessage(Dst, dstPostvisit, |
296 | 4.29k | *Msg, *this); |
297 | 4.29k | } |